[MPlayer-dev-eng] Fix the bug of -vo xv mode when use switch_ratio

The Wanderer inverseparadox at comcast.net
Tue Sep 9 15:08:13 CEST 2008


minyuanyang wrote:

> If i use switch_ratio switch the ratio  in -vo xv mode , 
> The screen  could  not  scale  normally .  
> So i  change the stretching method , below is the  patch 

> --- vo_xv.c    2008-09-06 12:23:44.000000000 +0800
> +++ vo_xv_2.c    2008-09-06 12:21:14.000000000 +0800

Patches should be made using 'svn diff' from the root of the source
tree, not using diff against a local copy from the same directory as the
file.

Patches should also be submitted as attachments, not inline.

Read DOCS/tech/patches.txt for the full patch submission rules.

> @@ -212,14 +215,14 @@
>  
>          xv_format = 0;
>          for (i = 0; i < formats; i++)
> -        {
> +         {

This is considered a cosmetic change, and as such should not be included
in any patch which makes non-cosmetic changes.

I think it unlikely that this particular change would be accepted in any
case, since there's no point to it and it breaks vertical alignment.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.



More information about the MPlayer-dev-eng mailing list