[MPlayer-dev-eng] [PATCH] Patch for better pause support.

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Sep 4 09:57:19 CEST 2008


On Wed, Sep 03, 2008 at 11:19:10PM -0400, Robert Cummings wrote:
> Specifically it doesn't set the pause status before entry
> into run_command().

What is the purpose of setting that (except your is_paused command)?
The reason I dislike it is because the variable is called "was_paused",
which implies it actually is no longer paused when it is set.
It may work well like that for now, but it seems like the kind of thing
that is guaranteed to be misunderstood and broken someonewhen in the
future.
And thanks for testing.

Greetings,
Reimar Doeffinger



More information about the MPlayer-dev-eng mailing list