[MPlayer-dev-eng] [PATCH] don't use libdvdnavmini

[Dominik 'Rathann' Mierzejewski]

On Sunday, 31 August 2008 at 23:07, Nico Sabbi wrote:
> Il giorno dom, 31/08/2008 alle 21.06 +0200, Dominik 'Rathann'
> Mierzejewski ha scritto:
> > On Sunday, 31 August 2008 at 15:55, Nico Sabbi wrote:
> > > Il giorno dom, 31/08/2008 alle 15.40 +0200, Diego Biurrun ha scritto:
> > > > On Sat, Aug 30, 2008 at 01:05:28AM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > > > 
> > > > > Since MPlayer no longer supports libdvdnav with its internal libdvdread,
> > > > > we shouldn't try to link against the minilib, but use the regular
> > > > > libdvdnav instead.
> > > > 
> > > > OK with me.
> > > > 
> > > > Diego
> > > 
> > > it wouldn't work: libdvdnav links against libdvdread (the external one)
> > > while libdvdnavmini doesn't. Expect every kind of symbol clash with
> > > -ldvdread
> > 
> > Have you actually tried building MPlayer with this patch and external
> > libdvdread and libdvdnav? I have and it builds just fine. There are
> > multiple "-ldvdread" entries in the final link command, but that is
> > not a problem.
> 
> but if you use -ldvdread you can't use the internal dvdread

You can't use it with current internal libdvdread anyway.
Oh wait, I see. You want to be able to replace internal
libdvdread with our fork as svn extern, right. But even so,
-ldvdnavmini should be passed only when we're compiling against
the future internal libdvdread, shouldn't it?

Regards,
R.

-- 
MPlayer http://mplayerhq.hu | Livna http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan