[MPlayer-dev-eng] [PATCH] Replaced deprecated QuickDraw calls in vo_quartz

[Guillaume POIRIER]

Hello,

On Wed, Oct 29, 2008 at 12:46 AM, David DeHaven <dave at sagetv.com> wrote:
>
>>  "_LoadLibraryA", referenced from:
>>  "_GetProcAddress", referenced from:
>
> QuickTime is not available in 64 bit. You have to use QTKit which
> doesn't quite do the same things. I doubt QuickTime will ever be
> ported to 64 bit so it's probably best to disable QT based code if
> building for x86_64 or ppc64 on a Mac.

Ok. They do go away when I pass --disable-qtx to MPlayer's configue.
Configure script should check if it can be compiled/linked IMHO.

Here's what link stage looks like now:
Undefined symbols:
  "_SetSystemUIMode", referenced from:
      _uninit in vo_macosx.o
      -[MPlayerOpenGLView fullscreen:] in vo_macosx.o
      -[MPlayerOpenGLView fullscreen:] in vo_macosx.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make: *** [mplayer] Error 1


>>  "_SetSystemUIMode", referenced from:
>
> http://developer.apple.com/documentation/Carbon/Conceptual/Carbon64BitGuide/PortingTo64Bit/chapter_4_section_4.html#/
> /apple_ref/doc/uid/TP40004381-CH3-SW14
>
> Specifically the line:
> Carbon Human Interface Toolbox. APIs such as the Window Manager, Menu
> Manager, Data Browser, HIView, HIToolbar, and HIArchive are not
> available to 64-bit applications. You must implement your user
> interface with Cocoa. See "Choosing a Development Path for Your Carbon
> User Interface."
>
> SetSystemUIMode is in HIToolbox so isn't available to 64 bit apps.
>
> Besides that Apple gives strong warnings NOT to use it. You should be
> using CoreGraphics instead. I don't know if the QT BeginFullScreen
> call is available through QTKit or not, that was another easy way to
> do it.

Ok, thanks for the explanation. I think that this patch should be
reviewed now and considered for inclusion.
Fullscreen support in 64 bits mode can be dealt with later.

Nicolas, Ulion, what do you think about the patch?

Guillaume
-- 
One should not give up hope on imbeciles. With a little training, you
can make them into soldiers.
 -- Pierre Desproges