[MPlayer-dev-eng] [PATCH] Replaced deprecated QuickDraw calls in vo_quartz

[Guillaume POIRIER]

Hello,

On Mon, Oct 27, 2008 at 7:54 PM, Gregor Riepl <onitake at gmail.com> wrote:
>> how about manually add it into head of our source file?
>>
>> #ifndef __POWER__
>> #include <OSServices/Power.h>
>> #endif
>
> since apple didn't respond to my bug report, i implemented your suggestion
> for both vo_macosx and vo_quartz.
> in case they do reply, i'll keep a patch of the IOPMAssertion method around.
>
> as i heard, your ppc64 died recently, guillaume, so i'm asking anyone with a
> 64bit 10.5 or 10.4 machine to test.

Luckily, I do have a MacBook Pro with Leopard on it:

Here's MacOSX VO:

gcc -arch x86_64 -Wdisabled-optimization -Wno-pointer-sign
-Wdeclaration-after-statement -std=gnu99 -Wall -Wno-switch
-Wpointer-arith -Wredundant-decls -O4   -pipe -ffast-math
-fomit-frame-pointer -mdynamic-no-pic -falign-loops=16 -shared-libgcc
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -I.
-I/usr/local/include -I/usr/X11/include -c -o libvo/vo_macosx.o
libvo/vo_macosx.m
libvo/vo_macosx.m:17:30: error: OSServices/Power.h: No such file or directory
libvo/vo_macosx.m: In function '-[MPlayerOpenGLView render]':
libvo/vo_macosx.m:783: warning: implicit declaration of function
'UpdateSystemActivity'
libvo/vo_macosx.m:783: error: 'UsrActivity' undeclared (first use in
this function)
libvo/vo_macosx.m:783: error: (Each undeclared identifier is reported only once
libvo/vo_macosx.m:783: error: for each function it appears in.)
make: *** [libvo/vo_macosx.o] Error 1


So unfortunately, it still fails :-(

> vo_quartz seems to be unworkable on 64bit,

Yep.


> but vo_macosx should be ok now if
> i didn't miss anything.

Unfortunately still not :-(


> i also have a question about
> #if !defined (CONFIG_MACOSX_FINDER) || !defined (CONFIG_SDL)
> is this really meant that way? only skip the code if both finder support and
> vo_sdl are enabled?
> i also wonder if the TransformProcessType() below is 64bit compatible (i
> already replaced the deprecated CPSEnableForegroundOperation with a
> TransformProcessType). it looks ok for vo_quartz, but there should be a
> better way for vo_macosx, imho.

I don't have an answer for that one though :-(


Guillaume
-- 
One should not give up hope on imbeciles. With a little training, you
can make them into soldiers.
 -- Pierre Desproges