[MPlayer-dev-eng] [PATCH] -volume

[rvm]

El Sábado, 25 de Octubre de 2008 15:48, RC escribió:
> Actually now more verbose than necessary, but it certainly explains it.
> I recomend Compn's version.

I haven't received Compn's post in my mailbox (my mail is working really bad 
lately), I had to read it in the archives. So I answer here.

Compn wrote:

> its ok, but the line about which is faster needs to be verified
> or thrown out. imo its not needed. how about:
> 
>    -volume <-1-100> (also see -af volume)
>           Set the startup volume in the mixer, either hardware or
>           software (if used with -softvol). A value of -1 (the
>           default) will not change the volume. 

I attach a new patch with your description. I have also added the Spanish 
translation for DOCS/man/es/mplayer.1.

> what happens when mplayer -volume 0 -af volume=10 file.avi ?
> -volume overrides -af volume i assume?

Yes. It actually changes the startup volume, if the user increases the volume 
-af volume still works as expected.
 
> -volume needs to be added to DOCS/tech/slave.txt (including the
> table at the bottom) if it works with slave... 

There was already a slave command for volume, which is also documented in 
DOCS/tech/slave.txt:

volume <value> [abs]
    Increase/decrease volume or set it to <value> if [abs] is nonzero.

...

 Available properties:

name               type      min     max     get set step comment
=================================================================
...
volume             float     0       100     X   X   X    change volume

> >+may have.
> > .
> > .
> >+.
> 
> extra line? 

No. There were 3 empty lines before my changes, and there are 3 empty lines 
now. I guess diff decided the last one is new instead of the first line 
(before ".TP").

-- 
rvm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: volume_manpage2.diff
Type: text/x-diff
Size: 1358 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081026/3ecc8ac0/attachment.diff>