[MPlayer-dev-eng] [PATCH] fix vo x11 in 15 bit color depth

Sascha Sommer saschasommer at freenet.de
Thu Oct 16 11:33:32 CEST 2008


Hi,

On Donnerstag, 16. Oktober 2008, compn wrote:
> On Wed, 15 Oct 2008 22:15:50 +0200, Sascha Sommer wrote:
> >while testing xvidix with my riva128 I noticed that MPlayer's vo_x11 no
> > longer works with 15 bit color depths.
> >
> >Format selection fails because the X server reports bit depth 16 for 15
> > bit formats.
> >
> >+      /* bits_per_pixel in X seems to be set to 16 for 15 bit formats
> >+         => force depth to 16 so that only the color masks are used for
> > the format check */ +      if(depth == 15)
> >+          depth = 16;
>
> no longer works? what error? this patch works on older x? what changed?
> x or vo_x11 ? how to reproduce? what x version? binary or free driver?
>

It broke in r20415 by reimar

"Proper detection of corresponding MPlayer image format for X server format 
for vo_x11."

MPlayer now reports "X server image format not supported, please contact the 
developers".

X Version is 7.2.0

The workaround should work with all X versions because red_mask, green_mask 
and blue_mask are enough to distinguish between the various rgb/bgr 15/16 bit 
formats.

Riva128 is not supported by any binary nvidia driver.

Regards

Sascha



More information about the MPlayer-dev-eng mailing list