[MPlayer-dev-eng] [RFC] build from a single ffmpeg subdirectory

Diego Biurrun diego at biurrun.de
Mon Oct 13 23:17:30 CEST 2008


I have had this in one of my local trees since forever and now finally
sat it down to finish it...

Here is an overhaul to the way we integrate FFmpeg with MPlayer.  It
switches over from multiple subdirectories (and corresponding svn
externals) to a single subdirectory for all of FFmpeg.  MPlayer's
configure calls FFmpeg's configure and FFmpeg is built separately from
the MPlayer build process.

pros:
- gets rid of a lot of duplicated code in the build system
- no more MPlayer build failures after changes to FFmpeg's build system
- needs just one svn:external, so it might work with git someday

cons:
- increases the size of the checkout as it pulls in unneeded parts of
  FFmpeg

still missing:
- an option for configure to pass options to FFmpeg's configure
- pass MPlayer's CFLAGS to FFmpeg's configure

In any case, the diffstat is pretty convincing:

 Makefile   |   34 +---
 common.mak |   96 -------------
 configure  |  440 ++-----------------------------------------------------------
 subdir.mak |   74 ----------
 4 files changed, 32 insertions(+), 612 deletions(-)

I'm getting more fond of this solution by the day, it reduces my
maintenance burden considerably.

Thoughts?

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: external_ffmpeg.diff
Type: text/x-diff
Size: 33972 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081013/79bb20bf/attachment.diff>


More information about the MPlayer-dev-eng mailing list