[MPlayer-dev-eng] [PATCH] use av_malloc/av_free instead of malloc where missing memalign

JonY 10walls at gmail.com
Mon Oct 13 17:03:36 CEST 2008


On 10/12/2008 07:30, Gianluigi Tiesi wrote:
> Hi,
>
> currently mplayer uses malloc instead of memalign when memalign is not
> supported.
>
> while often align(64) is used for perfomarnce reasons
>
> align(16) is needed for sse code
>
>
> The attached patch fixes it in dec_audio.c that avoids
> crash while decoding an ogg vorbis
>
> I've seen a similar patch in liba52 that checks for mingw+sse
> but I think it's better to check for missing memalign
>
> there are also other places to be fixed, but it's a bit
> dangerous, since free() needs to be mapped to av_free __only__
> if the buffer is allocated with av_malloc
> (audio_dec ->  a_buffer is ok to av_malloc/av_free,
> a_in_buffer leads to stack corruptions, free-ed somewhere else?)
>
> Regards
>
>

Ping.

This thread sounds awfully quiet.

I'd love to have ffaac and ffvorbis working on MinGW, but I couldn't 
test the patch, my usual windows box is down atm. Anybody else tested it?



More information about the MPlayer-dev-eng mailing list