[MPlayer-dev-eng] [PATCH] use av_malloc/av_free instead of malloc where missing memalign

[Gianluigi Tiesi]

On Sun, Oct 12, 2008 at 03:03:35AM +0300, Siarhei Siamashka wrote:
> On Sunday 12 October 2008, Gianluigi Tiesi wrote:
> > Hi,
> >
> > currently mplayer uses malloc instead of memalign when memalign is not
> > supported.
> >
> > while often align(64) is used for perfomarnce reasons
> >
> > align(16) is needed for sse code
> >
> > The attached patch fixes it in dec_audio.c that avoids
> > crash while decoding an ogg vorbis
> 
> I may be misinterpreting something (C99 draft and 'man malloc'), but isn't
> alignment of a pointer returned by malloc supposed to be sufficient for using
> it with any data type supported on the target platform? That would mean that
> the pointer returned by malloc must be at least 16 bytes aligned on the
> systems supporting SSE instructions.
> 
> If this is the case, reporting a bug against nonconforming C library
> implementation might be a good idea as well.

ehm what a fantastic world :D
mingw isn't even able to honour attribute aligned without -fno-common

Regards

-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/