[MPlayer-dev-eng] [PATCH] Fix packed YUV in dshow vo

Laurent laurent.aml at gmail.com
Mon Oct 6 20:49:14 CEST 2008


On 10/6/08, Laurent <laurent.aml at gmail.com> wrote:
> On 10/6/08, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> >
> > Hm, I didn't read the patch properly before, but now I realize: is that
> > not the same thing that
> > memcpy_pic(image, mpi->planes[0], FFMIN(source_stride, dest_stride), dest_stride, source_stride);
> > does?
> > Except that FFMIN(source_stride, dest_stride) should actually be width *
> > bytes_per_pixel.
>
> That's it.
> This is definitely how other VOs are handling Packed YUV copy (eg vo_xv.c).

Though memcpy_pic is working, it seems that that directx vo also uses
mem2agpcpy_pic.
Is mem2agpcpy_pic preffered over memcpy_pic for directx?

Thanks,
Laurent



More information about the MPlayer-dev-eng mailing list