[MPlayer-dev-eng] [PATCH]Remove duplicated const

Uoti Urpala uoti.urpala at pp1.inet.fi
Mon Oct 6 00:29:35 CEST 2008


On Mon, 2008-10-06 at 00:57 +0200, Carl Eugen Hoyos wrote:
> Attached patch removes one of two const's in two lines in 
> libmpdemux/demux_ty_osd.c and fixes warnings when using icc.

> -static const char const *TY_XDS_CHIP[ 2 ][ 8 ] = 
> +static const char *TY_XDS_CHIP[ 2 ][ 8 ] = 

> -static const char const *TY_XDS_modes[] = 
> +static const char *TY_XDS_modes[] = 

Those are not duplicated but rather the second one is misplaced. It
should not be removed. The correct version is:

static const char * const TY_XDS_CHIP[ 2 ][ 8 ] = 

It's obviously supposed to be a constant table of pointers, each
pointing to a string constant. Your version would be a table of
modifiable pointers which initially point to the string constants given.




More information about the MPlayer-dev-eng mailing list