[MPlayer-dev-eng] [PATCH]Silence a few icc warnings

Carl Eugen Hoyos cehoyos at rainbow.studorg.tuwien.ac.at
Mon Oct 6 00:59:46 CEST 2008


Hi!

Attached patch silences five icc warnings by using defines instead of the 
respective numeric values.

I'll apply the patch later this week if nobody objects, Carl Eugen
-------------- next part --------------
Index: libao2/ao_alsa.c
===================================================================
--- libao2/ao_alsa.c	(Revision 27720)
+++ libao2/ao_alsa.c	(Arbeitskopie)
@@ -192,7 +192,7 @@
 	set_vol = vol->left / f_multi + pmin + 0.5;
 
 	//setting channels
-	if ((err = snd_mixer_selem_set_playback_volume(elem, 0, set_vol)) < 0) {
+	if ((err = snd_mixer_selem_set_playback_volume(elem, SND_MIXER_SCHN_FRONT_LEFT, set_vol)) < 0) {
 	  mp_msg(MSGT_AO,MSGL_ERR,MSGTR_AO_ALSA_ErrorSettingLeftChannel, 
 		 snd_strerror(err));
 	  return CONTROL_ERROR;
@@ -201,7 +201,7 @@
 
 	set_vol = vol->right / f_multi + pmin + 0.5;
 
-	if ((err = snd_mixer_selem_set_playback_volume(elem, 1, set_vol)) < 0) {
+	if ((err = snd_mixer_selem_set_playback_volume(elem, SND_MIXER_SCHN_FRONT_RIGHT, set_vol)) < 0) {
 	  mp_msg(MSGT_AO,MSGL_ERR,MSGTR_AO_ALSA_ErrorSettingRightChannel, 
 		 snd_strerror(err));
 	  return CONTROL_ERROR;
@@ -221,9 +221,9 @@
 	}
       }
       else {
-	snd_mixer_selem_get_playback_volume(elem, 0, &get_vol);
+	snd_mixer_selem_get_playback_volume(elem, SND_MIXER_SCHN_FRONT_LEFT, &get_vol);
 	vol->left = (get_vol - pmin) * f_multi;
-	snd_mixer_selem_get_playback_volume(elem, 1, &get_vol);
+	snd_mixer_selem_get_playback_volume(elem, SND_MIXER_SCHN_FRONT_RIGHT, &get_vol);
 	vol->right = (get_vol - pmin) * f_multi;
 
 	mp_msg(MSGT_AO,MSGL_DBG2,"left=%f, right=%f\n",vol->left,vol->right);
Index: libvo/vo_sdl.c
===================================================================
--- libvo/vo_sdl.c	(Revision 27720)
+++ libvo/vo_sdl.c	(Arbeitskopie)
@@ -1120,7 +1120,7 @@
 {
 	struct sdl_priv_s *priv = &sdl_priv;
 	SDL_Event event;
-	SDLKey keypressed = 0;
+	SDLKey keypressed = SDLK_UNKNOWN;
 	
 	/* Poll the waiting SDL Events */
 	while ( SDL_PollEvent(&event) ) {


More information about the MPlayer-dev-eng mailing list