[MPlayer-dev-eng] [PATCH]Remove useless (?) line from demux_audio.c

Carl Eugen Hoyos cehoyos at rainbow.studorg.tuwien.ac.at
Mon Oct 6 00:52:26 CEST 2008


Hi!

Attached patch (that fixes an icc warning) removes a line from 
libmpdemux/demux_audio.c that sems to be useless: w->cbSize is of type 
unsigned short, (stream_read_word_le is unsigned int,) so (w->cbSize < 0) 
can't be true.

I'll apply later this week if nobody objects, Carl Eugen
-------------- next part --------------
Index: libmpdemux/demux_audio.c
===================================================================
--- libmpdemux/demux_audio.c	(Revision 27720)
+++ libmpdemux/demux_audio.c	(Arbeitskopie)
@@ -392,7 +392,6 @@
     l -= 16;
     if (l >= 2) {
       w->cbSize = stream_read_word_le(s);
-      if (w->cbSize < 0) w->cbSize = 0;
       l -= 2;
       if (l < w->cbSize) {
         mp_msg(MSGT_DEMUX,MSGL_ERR,"[demux_audio] truncated extradata (%d < %d)\n",


More information about the MPlayer-dev-eng mailing list