[MPlayer-dev-eng] [PATCH] Replaced deprecated QuickDraw calls in vo_quartz

[Guillaume POIRIER]

Hello,

On Fri, Oct 3, 2008 at 5:49 PM, Gregor Riepl <onitake at gmail.com> wrote:
> here's an updated patch. i don't suggest applying it yet, as it switches to
> IOPMAssertion when compiling for 10.5, and the screensaver is still on. but
> you can test if it works on x86_64, if you like.

I tested your patch on 10.4.11/PPC, and it doesn't compile:

cc -Wdisabled-optimization -Wno-pointer-sign
-Wdeclaration-after-statement -std=gnu99 -Wall -Wno-switch
-Wpointer-arith -Wredundant-decls -O4 -mcpu=970 -mtune=970 -pipe
-ffast-math -fomit-frame-pointer -maltivec -mabi=altivec
-mdynamic-no-pic -falign-loops=16 -shared-libgcc -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -I. -I/opt/local/include/
-I/usr/local/include -I/usr/X11R6/include
-I/opt/local/include/freetype2 -I/opt/local/include -c -o
libvo/vo_macosx.o libvo/vo_macosx.m
In file included from libvo/vo_macosx.m:9:
libvo/vo_macosx.h:69: error: parse error before 'IOPMAssertionID'
libvo/vo_macosx.m: In function '-[MPlayerOpenGLView fullscreen:]':
libvo/vo_macosx.m:827: warning: implicit declaration of function
'IOPMAssertionCreate'
libvo/vo_macosx.m:827: error: 'kIOPMAssertionTypeNoDisplaySleep'
undeclared (first use in this function)
libvo/vo_macosx.m:827: error: (Each undeclared identifier is reported only once
libvo/vo_macosx.m:827: error: for each function it appears in.)
libvo/vo_macosx.m:827: error: 'kIOPMAssertionLevelOn' undeclared
(first use in this function)
libvo/vo_macosx.m:827: error: 'assertionID' undeclared (first use in
this function)
libvo/vo_macosx.m:866: warning: implicit declaration of function
'IOPMAssertionRelease'
make: *** [libvo/vo_macosx.o] Error 1


I do understand that your patch is not supposed to be finished yet,
but I'd like to remind you that MPlayer should be kept backward
compatible with 10.4 since Tiger packs everything that is needed for
MPlayer to work well, and Tiger is also the last OS with which PPC
machines have been shipped. I don't want to break support for that.

Guillaume
-- 
One should not give up hope on imbeciles. With a little training, you
can make them into soldiers.
 -- Pierre Desproges