[MPlayer-dev-eng] pkgconfig's cflags honoring (was: Re: [PATCH] Fix compilation on OpenBSD)

[Andrew Savchenko]

Hi,

On Friday 28 November 2008 12:41, Diego Biurrun wrote:
[...]
> > +  test $_pkg_config == "false" || _inc_theora="`$_pkg_config
> > --silence-errors --cflags theora`"
>
> Using == in 'test' invocations is a bashism.
>
> Also, the value of _pkg_config is the *program* false, so that
> all invocations of pkg-config via $_pkg_config will simply fail
> cleanly.  So you can simply execute the command and react
> according to the return value.

Return value check is the same as previos solution in terms of 
complexity, but if in your opinion check of return value is more 
elegant solution, so it should be.

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: theora_include.patch
Type: text/x-diff
Size: 650 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081129/0f53e341/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081129/0f53e341/attachment.pgp>