[MPlayer-dev-eng] pkgconfig's cflags honoring (was: Re: [PATCH] Fix compilation on OpenBSD)

[Andrew Savchenko]

On Tuesday 18 November 2008 12:58, Andrew Savchenko wrote:
[...]
> > Hmmm, /usr/local/include should always be in the search
> > path...
>
> Maybe, I dunno, I suppose some feature of OpenBSD.
> By the way I can't find standard include search path
> specifications in gcc manual... And gcc -print-search-dirs says
> nothing about them.
>
> Nevertheless instead of /usr/local/include it may be (in theory)
> /some/very/tricky/patch/to/the/library/header here.
>
> > > --- configure	(revision 27949)
> > > +++ configure	(working copy)
> > > @@ -6055,6 +6055,7 @@
> > >  EOF
> > >    for _ld_theora in "`$_pkg_config --silence-errors --libs
> > > --cflags theora`" "-ltheora -logg"; do cc_check $_ld_theora
> > > && _ld_extra="$_ld_extra $_ld_theora" \ +
> > > && _inc_extra="$_inc_extra `$_pkg_config --silence-errors
> > > --cflags theora`" \ && _theora=yes && break
> > >    done
> >
> > Hmm, that will subtly break if the pkg-config call fails, but
> > Theora is installed.
>
> Agreed. I missed that. What about the following patch?
> Should we add similar changes for all pkg-config detected
> libraries where this kind of behaviour may be required?

ping

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081126/735d0bfe/attachment.pgp>