[MPlayer-dev-eng] [PATCH] enable compilation of vo_macosx.m in 64-bits mode

[Reimar Döffinger]

On Mon, Nov 24, 2008 at 12:13:57PM +0100, Guillaume Poirier wrote:
> @@ -328,8 +334,9 @@
>  	{
>  		#if !defined (CONFIG_MACOSX_FINDER) || !defined (CONFIG_SDL)
>  		//this chunk of code is heavily based off SDL_macosx.m from SDL 
> -		//it uses an Apple private function to request foreground operation
> -		void CPSEnableForegroundOperation(ProcessSerialNumber* psn);
> +		//the CPSEnableForegroundOperation that was here before is private and shouldn't be used
> +		//replaced by a call to the 10.3+ TransformProcessType
> +		{
>  		ProcessSerialNumber myProc, frProc;
>  		Boolean sameProc;
>  

Huh, I can't see the point of the extra {, there is no code between the
previous one and the declarations...

> @@ -339,11 +346,12 @@
>  			{
>  				if (SameProcess(&frProc, &myProc, &sameProc) == noErr && !sameProc)
>  				{
> -					CPSEnableForegroundOperation(&myProc);
> +					TransformProcessType(&myProc, kProcessTransformToForegroundApplication);

And IMO the comment makes more sense here (if you really want you can
move the previous comment and function prototype in this block first).
Also this seems to be about 64 bit support, so why do we care if it
private here? If the real reason is that CPSEnableForegroundOperation is
not available on 64 bit, then write that, otherwise this is more a
"cosmetic" change and has not place in this patch.

Greetings,
Reimar Döffinger