[MPlayer-dev-eng] [PATCH] Replaced deprecated QuickDraw calls in vo_quartz

[Diego Biurrun]

On Tue, Nov 18, 2008 at 11:01:15AM +0100, Guillaume POIRIER wrote:
> 
> On Thu, Nov 13, 2008 at 1:18 AM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Wed, Oct 29, 2008 at 07:26:58PM +0100, Gregor Riepl wrote:
> >>
> >> here's the updated patch.
> >
> > Here is a preliminary review...
> >
> >> +  if cc_check -framework CoreAudio; then
> >> +    _ld_extra="$_ld_extra -framework CoreAudio -framework AudioUnit -framework AudioToolbox"
> >> +    _coreaudio=yes
> >> +    _def_coreaudio='#define CONFIG_COREAUDIO 1'
> >> +    _aosrc="$_aosrc ao_macosx.c"
> >> +    _aomodules="macosx $_aomodules"
> >> +  else
> >> +    _coreaudio=no
> >> +    _def_coreaudio='#undef CONFIG_COREAUDIO'
> >> +    _noaomodules="macosx $_noaomodules"
> >> +  fi
> >> +  cat > $TMPC <<EOF
> >>  #include <Carbon/Carbon.h>
> >>  #include <QuickTime/QuickTime.h>
> >> -#include <CoreAudio/CoreAudio.h>
> >>  int main(void) {
> >
> > It would be good if this ao_macosx check could be a separate patch.
> 
> Ok, but other then that, it's OK? I can commit hunks seperately.

Other than that the hunk is OK, commit it.

Diego