[MPlayer-dev-eng] [PATCH] Re : Re : Direct3D vo performance increase

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Nov 23 18:31:19 CET 2008


Hello,
On Sun, Nov 23, 2008 at 07:06:40PM +0200, Georgi Petrov wrote:
> Ok, it was very uncomfortable for me, but I did it. I'm ready with 4
> different patches for all thing that did happen last days (exlcuding
> OSD).
> 
> I attach 3 of them here:
> 
> 1_vo_direct3d_remove_is_cfg: removes logic around the unusused anymore
> "is_cfg_finished" variable.

Applied.

> 2_vo_direct3d_perf_patch: the performance patch itself. Excluding
> Begin/End scene movement. It breakes vo_direct3d.c!!!!!!!!

This violates the SVN policy rule number one. It also means that most of
the advantages of splitting the patch no longer apply.
For fixing I suggest this: please test my patch that moves the Begin/End
scene. If it works I will apply it.
In the meanwhile you make a copy of the vo_direct3d.c file as it is
after you apply your patches 2 and 3, then move it somewhere else.
The you run SVN update, copy back the file and create a patch.
Voilà patch split the proper way at almost no effort.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list