[MPlayer-dev-eng] [PATCH] yadif SSE2/SSSE3 optimization

[Michael Niedermayer]

On Sat, Nov 22, 2008 at 12:14:06PM +0800, Zhou, Zongyi wrote:
[...]
> 
> >also please split the cosmetic stuff like above into a seperate 
> >patch from the additon of SSE2. This makes the code much easier to 
> >review as first just needs to be checked for not "changing" anything 
> >and the second patch likely will be rather small
> 
> It is impossible. I cannot add SSE2 without such "cosmetic" stuff because all these modifications
> (e.g. "LOAD4" to "LOAD") are made to factorize duplicated codes to macros as you requested.
> They are to be used by both MMX2 and SSE2 so i cannot seperate them into two patches.

cosmetic patch:
- "paddw       %%mm3, "%%mm2 \n\t"\
+ "paddw       "MM"3, "MM"2 \n\t"\
...
+#define MM "%%mm"
...
+FILTER_LINE_ROUTINE(mmx2)


SSE2 adding patch:
+#undef MM
+#define MM "%%xmm"
...
+FILTER_LINE_ROUTINE(sse2)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081123/5e02c9f2/attachment.pgp>