[MPlayer-dev-eng] [PATCH] Re : Direct3D vo performance increase

Georgi Petrov gogothebee at gmail.com
Sun Nov 23 00:59:37 CET 2008


Great guys. Tomorrow I'll take a look at Reimar's patch, so we can
finally get this performance patch in the three as three separate
patches:
1. The performance patch itself
2. The movement of Begin/End scene
3. Coding style Dst->dst and UVscene -> uv_scene

> I have a question?
>
> what's priv->is_cfg_finished for?
>

It was my ingenious decision for multithreading race condition, which
as you said wasn't working at all. It kind of worked long time ago
when I implemented window management code, but I think that now it's
not needed anymore. Should I remove this variable and the logic around
it in a separate patch (so we have 4 total)?

BTW the problem with  priv->is_cfg_finished was that reconfigure_d3d
had to be called from WM_SIZE for example and I think that all WM_*
code executes from a different thread. I had situations when
reconfigure_d3d is called BEFORE previous reconfigure_d3d was
finished. However with the current code I doubt it ever happens again
:)



More information about the MPlayer-dev-eng mailing list