[MPlayer-dev-eng] [PATCH] yadif SSE2/SSSE3 optimization

[Zhou, Zongyi]

Hi Michael,

Well I am getting confused.

>please dont add tabs to vf_yadif.c whitespce should be just spaces 

There are tabs everywhere in vf_yadif.c. Should i replace other tabs with spaces in the patch?

>also please split the cosmetic stuff like above into a seperate 
>patch from the additon of SSE2. This makes the code much easier to 
>review as first just needs to be checked for not "changing" anything 
>and the second patch likely will be rather small

It is impossible. I cannot add SSE2 without such "cosmetic" stuff because all these modifications
(e.g. "LOAD4" to "LOAD") are made to factorize duplicated codes to macros as you requested.
They are to be used by both MMX2 and SSE2 so i cannot seperate them into two patches.

Yes I know it is not easy to review this patch. Actually I don't like such way of coding either. 
I was simply following what you asked me to do.

Regards,

ZZ