[MPlayer-dev-eng] [PATCH] vf_screenshot, output filename corresponding to the played file

[Ruslan Savchenko]

On Sat, Nov 22, 2008 at 12:56 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Nov 21, 2008 at 02:17:32PM +0300, Ruslan Savchenko wrote:
>> On Mon, Nov 17, 2008 at 9:10 PM, Ruslan Savchenko
>> <ruslan.savchenko at gmail.com> wrote:
>> > 2008/11/15 Michael Niedermayer <michaelni at gmx.at>:
>> >> On Sat, Nov 15, 2008 at 03:03:41AM +0300, Ruslan Savchenko wrote:
>> >>> On Sat, Nov 15, 2008 at 2:47 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >>> > On Sat, Nov 15, 2008 at 02:28:03AM +0300, Ruslan Savchenko wrote:
>> >>> >> On Sat, Nov 15, 2008 at 1:16 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >>> >> > On Fri, Nov 14, 2008 at 10:24:47PM +0300, Ruslan Savchenko wrote:
>> >>
>> >> both attached patches look ok IMHO
>> >>
>> >
>> > Any news?
>> > I think I should wait until those will be applied/rejected before
>> > proposing next patches. Right?
>>
>> Since I get no response, I send the whole updated patch once again.
>
> well and i have to reject it as it contains changes that should be seperate
> patches. And actually are but the patch now contains them too.
> Do you think if noone applied a 2 line patch that someone will apply a much
> larger patch that contains these 2 lines as well ...

Please do not misunderstand. I just wanted to show what I want to do
next in case those two one-line patches will be applied.

>
> Actually i would suggest that you split the filename and timestamp in name
> things in 2 patches as well.

I don't understand what do you want me to do. Split patch into many
little ones and send them all in one email? I can do this but using
diff, not svn diff.

>
> [...]
>> +        break;
>> +    default:
>> +    case 0:
>> +        /* Enough memory for "shotXXXXX.png" filename */
>> +        priv->fname = malloc(SHOT_FNAME_LENGTH);
>> +        if (!priv->fname) {
>> +            mp_msg(MSGT_VFILTER,MSGL_ERR,"Unable to allocate memory in vf_screenshot.c\n");
>> +            return;
>> +        }
>>      do {
>> -     snprintf (priv->fname, 100, "shot%04d.png", ++priv->frameno);
>> +     snprintf (priv->fname, SHOT_FNAME_LENGTH, "shot%04d.png", ++priv->frameno);
>>      } while (fexists(priv->fname) && priv->frameno < 100000);
>
> please avoid mixing tabs and spaces in indention
> also a patch changing all tabs in vf_screenshot to spaces is probably
> welcome, at least id approve it if noone objects.

Well, I'll try to make this one against the current svn.


-- 
Regards,
savrus