[MPlayer-dev-eng] [PATCH] panscan for vo_direct3d

[Reimar Döffinger]

On Fri, Nov 21, 2008 at 05:54:01PM +0200, Georgi Petrov wrote:
> Please - write to me when you're ready with the panscan fix I send few
> hours ago, so I can submit Jim's patch relative to panscan's fixed
> code!

If that one line holds you up you are doing something wrong with how you
handle patches.
Just send the modified patch as it is, besides line numbers shifting a bit (which
"patch" does not care about) the patch will be unchanged whether that
chunk is applied or not.
You could also have both on your tree and just manually delete that hunk
from the patch.
And lastly, I think that your suggested patch is a bad idea because:
1) Clear will be called outside BeginScene/EndScene which I am not sure
if that is valid
2) There is already a ColorFill function, which a) does not work for me and b)
the functionality of which you would duplicate, just in a slightly
different way, which always is a sure way to increase the number of
bugs.
3) both calls are placed so inconveniently that you'd have to add a
third one once you implement OSD.

> so I don't how SVN will handle variable/function
> renaming by itself.

Very badly. Merging works only when the patches modify different parts
of the code, but then it works without issues.

Greetings,
Reimar Döffinger