[MPlayer-dev-eng] [PATCH] panscan for vo_direct3d

[Reimar Döffinger]

On Thu, Nov 20, 2008 at 11:54:10PM +0200, Georgi Petrov wrote:
> The only thing that bothers me just a little is that we always pass
> src/dest RECTs to StretchRect, even when we need to uset the whole
> src/dst RECTs. Is it possible that this is slower?

It is possible, but seems unlikely. While you never know if the
actual programmers wrote it, the description sounds like they are doing
something like
real_rect = user_rect ? user_rect : fullsize_rect;
in their code.

> The black border - it's fixed easy. In static void calc_fs_rect(void)
> add the following line after "if (!vo_fs) return;":
> 
> IDirect3DDevice9_Clear (priv->d3d_device, 0, NULL, D3DCLEAR_TARGET, 0, 0, 0);

Thing is, it seems to happen also when just switching to fullscreen,
without panscan, and there is already a ColorFill.
Though i just realize that the ColorFill is probably outside the
BeginScene, that might cause it...
Maybe a needs_clear flag and then clearing in the draw_frame if it is
set would be better...

Greetings,
Reimar Döffinger