[MPlayer-dev-eng] Update to vo_direct3d - saves ~2% CPU time

Jim Hauxwell james at dattrax.co.uk
Thu Nov 20 21:53:37 CET 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This should be compared to locking all of it for the first slice and
unlocking only directly before the StretchRect (or before the BeginScene
if combined with your other change).
I am not sure that the LockRect/UnlockRect are low enough overhead that
you actually gain something by having more than one DMA transfer.


I considered this, but microsoft docs say that you should not hold a
lock open for a long time, so I went with this approach.

The other issue you get into is that you could have a surface which is
held in a locked state and therefore not discarded properly.

I think there is already an issue with lost surfaces through the
IDirect3DDevice9_CreateOffscreenPlainSurface() call.  I need to check up
on that.


I may have lost the plot here, but why does it 'have to be a separate
patch'?  Its a performance increaser patch which does exactly that.  All
the issues in the patch are to do with performance enhancement.


Jim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkklzlEACgkQhrNWoHjgI1AlxQCggKl/kZ0V+fGC0yCp9mY3DWkV
pV8AnjhdgEr/N0JBZYGEU/Sq4UexiXRX
=jekz
-----END PGP SIGNATURE-----




More information about the MPlayer-dev-eng mailing list