[MPlayer-dev-eng] [PATCH] Direct3D libvo driver

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Nov 20 00:40:16 CET 2008


On Thu, Nov 20, 2008 at 12:41:40AM +0200, Uoti Urpala wrote:
> IMO your comments about "favourite bikeshed after the fact" and "create
> extra work for everyone but themselves" are groundless and unnecessarily
> hostile. Consistent coding style is not a "bikeshed", and the author of
> the code was already talking about it. Overall you complain about
> smaller issues than I do. So if I sometimes mention an issue you don't
> particularly care about yourself it does IMO not justify such hostility.

You are coming now after this has been discussed since quite some time
with things that will result in a huge patch for which there is the
option to either commit it blindly or review a patch larger than the
original code, and I don't see you helping with either.
Or IOW you are screwing up my feeble attempts at resource management.
And I am not sure I care any less about consistent coding style than
you, but there are far more important things and this IMO was absolutely the
very worst possible time to start it.
Yes, I probably should have warned that I intented to commit but I did
not realize that actually anyone cared to even look at it.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list