[MPlayer-dev-eng] [PATCH] Replaced deprecated QuickDraw calls in vo_quartz

Guillaume Poirier gpoirier at mplayerhq.hu
Wed Nov 19 16:33:24 CET 2008


Hello,

Gregor Riepl wrote:
> sorry, didn't have time to comment on your last mail. so i'm replying  
> to this.
>
>   
>> I tested to pass -x objective-c to cc_check and it doesn't work.
>> That's probably because -x option is sensitive to its place on the
>> command line.
>> As you probably saw, the temporary is to modify the CFLAGS temporarily
>> before running the cc_check, then restoring the CFLAGS to their
>> original.
>>     
>
> yes, this is exactly the case. the -x argument applies to all source  
> files that follow, so it's vital to be placed in front of the  
> conftest.c. i tried experimenting with a new objc_check(), but since  
> gcc is used for both c and obj-c, it seemed overkill to me. would it  
> be possible to modify compile_check() so that it moves its compiler  
> arguments in front of the source file? or does that break everything?
>   

I let Diego answer this question.


>> Anyay, the attached patch removes some more cosmetics from Gregor's
>> original patch.
>>
>> Since I haven't heard a thing from any OSX devels from MPlayer dev
>> team, I shall start pushing these changes to MPlayer dev tree soonish.
>>     
>
> thank you :)
>
> by the way, my old macbook died last weekend,

That's sad news. Please receive all my sympathy: the screen of my
MacBookPro got broken last summer, and my G5 is at the repair shop. This
has been a bad year for me savings-wise.


>  so i had to buy a new  
> one. i can do 64bit compilation and testing directly now.
>   
Awesome.


> by the way, i didn't manage to crosscompile mplayer for x86_64-darwin  
> before. despite forcing --target and --enable-crosscompile, the  
> configure script would still try to execute its cpu test program,  
> complain and not create the correct config.h/config.mak.
>   

It works here with the following commandline:

CC="gcc -arch x86_64" ./configure --target=x86_64-darwin
--disable-liba52-internal --disable-qtx

Guillaume



More information about the MPlayer-dev-eng mailing list