[MPlayer-dev-eng] [PATCH] factor common code to handle -wid, vo_gc creation etc. out into x11_common.c

[Reimar Döffinger]

On Sun, Nov 16, 2008 at 09:08:41PM +0200, Ivan Kalvachev wrote:
> However when we use window of another program we can't resize it,  so
> instead  we get its dimensions and draw the video image so it fits in
> the existing window while preserving the correct aspect.

No, that behaviour is only used for the root window (and even there
inconsistently). Aspect is not preserved with -wid, the whole window is
filled - also the code stored the -wid window aspect as movie aspect,
which makes it make even less sense.
Making this behaviour optional (re-/mis-using the -fs flag for that was
my idea, though something that works for MPlayer created windows is
nice, too) sounds useful, but as long as the code is duplicate in about
7 places with slight variations each time it is just not feasible.

> Not mentioning the "know" issues that mplayer uses old values after
> resolution changes (both ctrl+alt+plus/minus and randr)

To my knowledge MPlayer is only aware of the virtual desktop resolution
and does not care what resolution is actually on screen, so this not
really a question of using "old" values but just generally wrong ones
(luckily they are rarely wrong in practice).
The "old values" problem does exist when moving between xinerama screens
though, it might not be that hard to solve but since things work fine
for LCDs it seems questionable if it's worth the effort of fixing it.

Greetings,
Reimar Döffinger