[MPlayer-dev-eng] [PATCH] Direct3D libvo driver

[Diego Biurrun]

On Thu, Nov 13, 2008 at 11:30:02PM +0200, Georgi Petrov wrote:
> 
> You can take a look at the implementation of all other things I
> changed. I submit the patch with .txt extension for supposedly easier
> quoting .

Note that some people manage to post patches with the correct mimetype.
Maybe one of them can enlighten us what the magic recipe is.

> --- libvo/vo_direct3d.c	(revision 0)
> +++ libvo/vo_direct3d.c	(revision 0)
> @@ -0,0 +1,1005 @@
> +/*
> + * vo_direct3d.c: Experimental Direct3D 9 driver

We know the filename, leave this out.

> + * Last modified: 13.11.2008, Version 0.0.3

This is redundant information, Subversion keeps track of changes for us.

> +static const vo_info_t info =
> +{
> +    "Direct3D 9 Experimental Renderer",

How experimental is it?

> +/*
> + * Global config variables. Every global variable is
> + * defined in gConfig to make the difference easier.

I don't understand "make the difference easier".

> +    const unsigned int  MPlayerFormat; /**< Given by Mplayer */

Please do not misspell MPlayer.

> +    /* Create the application's window. Depending from what do we need,

Depending on what we need,

> +        /* Center the movie realtive to it's height */

relative, its

> +/** @brief Shutdown Direct3D and close the window

nit: Please end complete sentences in a period, same in other places.

> +/** @brief libvo Callback: Preinitialize the Video card

video card

Throughout your comments you seem to capitalize some words at random.

> --- libvo/video_out.c	(revision 27905)
> +++ libvo/video_out.c	(working copy)

OK

> --- configure	(revision 27905)
> +++ configure	(working copy)
> @@ -8322,6 +8348,7 @@
>  $_def_directfb_version
>  $_def_directx
> +$_def_direct3d
>  $_def_dvb

This was previously in alphabetical order.

> --- DOCS/tech/MAINTAINERS	(revision 27905)
> +++ DOCS/tech/MAINTAINERS	(working copy)
> @@ -164,6 +164,7 @@
>      * vo_directfb[2].c - Jiri Svoboda
>      * vo_directx.c - Sascha Sommer
> +    * vo_direct3d.c - Georgi Petrov
>      * vo_dxr2.c - Alban Bedel

ditto

Diego