[MPlayer-dev-eng] [PATCH] yasm support

[Andrew Savchenko]

Hi,

On Tuesday 11 November 2008 18:25, Diego Biurrun wrote:
[...]
> > --- configure	(revision 27899)
> > +++ configure	(working copy)
> > @@ -2385,7 +2403,41 @@
> >
> > +echocheck "yasm"
> > +if test -z "$YASMFLAGS" ; then
> > +  if darwin ; then
> > +    if x86_64 ; then
> > +      objformat="macho64"
> > +    else
> > +      objformat="macho"
> > +    fi
>
> x86_64 && objformat="macho64" || objformat="macho"

Fixed as macho32 instead of macho as suggested by vmrsss.

> > @@ -7797,6 +7849,7 @@
> >  CC = $_cc
> >  CXX = $_cc
> > +YASM = $_yasm
> >  HOST_CC = $_host_cc
> >  INSTALL = $_install
>
> Put it after HOST_CC.

Done.

> > @@ -7983,6 +8037,7 @@
> >
> >  # Some FFmpeg codecs depend on these. Enable them
> > unconditionally for now. CONFIG_FFT=yes
> > +CONFIG_FFT_MMX=$(test $_yasm && test "$_mmx" == "yes" && echo
> > yes)
>
> This is not the way to go.  There should be no logic in this
> place.
>
> > @@ -8007,6 +8062,7 @@
> >
> >  HAVE_PTHREADS = $_pthreads
> >  HAVE_W32THREADS = $_w32threads
> > +HAVE_YASM=$(test $_yasm && echo yes)
>
> Ditto, set a variable that you can use here above.

I hope these issues are fixed now.

P.S. Sorry for delay, my old mail server was badly broken...

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: yasm.patch
Type: text/x-diff
Size: 4192 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081114/83528a91/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081114/83528a91/attachment.pgp>