[MPlayer-dev-eng] [PATCH] Direct3D libvo driver

[Reimar Döffinger]

On Thu, Nov 13, 2008 at 10:15:33AM +0200, Georgi Petrov wrote:
> Diego, I've fixed everything you suggested. I removed my name from
> every function, as well as the date and put them in the beginning of
> the file. Now all lines are less than 80 columns as well and all
> functions with no parameters are declared void.

Not quite, your patch still shows e.g. the --enable-bl line that has
nothing to do with anything you changed. Maybe you used an editor that
changes all tabs to spaces or vice versa?
Your diff should only contain the minimum number of changes to get the
new functionality.

> Reimar, thanks for pointing out w32_common.c - I didn't even know
> about it. I will take a look at it and will try to use as much common
> code as possible.

It may still be vo_gl specific in some places, if so tell me and I'll
try to fix it.
What it handles is at least: creating a window,
going fullscreen (automatically either on the current screen, or the
one specified with xineramascreen or all), handling -geometry,
toggling window borders, creating a child window in case of -wid (since
NVidia drivers can not handle when you create a 3D context for a window
owned by a different process, so you can not use the -wid window
directly, which IMO is a bug but unlikely to be fixed) and several
more things.

> Just one last question: how do you prefer that I reply on different
> mails with questions: to everyone who asked me something or like this
> one - to many people as reply to the last person? I know this question
> sounds stupid, but...

Who you reply to does not matter so much (though individually IMO is
preferred), but you should quote the question you answer above, like I
did here.

Greetings,
Reimar Doeffinger