[MPlayer-dev-eng] [PATCH] correct illegal instruction on < armv5tE

[GNUtoo at no-log.org]

>> On Thu, Nov 06, 2008 at 11:59:53PM +0100, GNUtoo at no-log.org wrote:
>>> > on Sunday 12 October 2008, GNUtoo at no-log.org wrote:
>>> >
>>> > Hmm, ifdefs around every instruction look extremely ugly. In
>>> > addition, they have exactly the same effect as just removing all
>>> > PLD instructions even for ARM cores that support cache prefetch
>>> > (HAVE_ARMV5TE is never defined when compiling this assembly file).
>>> I looked at the configure file of mplayer trunk and there is the
>>> following
>>> inside:
>>> if arm ; then
>>>   echocheck "ARM pld instruction"
>>>   cat > $TMPC << EOF
>>> int main(void) { __asm__ volatile ("pld [r0]"); return 0; }
>>> EOF
>>>   pld=no
>>>   cc_check && pld=yes
>>>   echores "$pld"
>>> so if I add the following to the beginning of the assembly file would
>>> it
>>> work?
>>> #ifndef HAVE_PLD
>>> .macro pld reg
>>> .endm
>>> #endif
>>> More precisely is the checks in the configure script enough or should I
>>> also add that in the configure script:
>>> enabled armv4l  && check_asm pld     '"pld [r0]"'
>>
>> What we have is enough.  It accomplishes exactly what you need.
>>
>> Diego
> Thanks a lot!!!
> I attached the patch for applying the following code to the
> libmpeg2/motion_comp_arm_s.S:
> #ifndef HAVE_PLD
> .macro pld reg
> .endm
> #endif_______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
I was forgetting to tell the test setup:
on my computer:
mencoder matrixbench_normdivx_vbrmp3.avi -oac none -ovc lavc -lavcopts
vcodec=mpeg2video -of mpeg -o matrix_openmoko.mpeg2
on the device:
DISPLAY=:0 mplayer -ao null -vo xv -fs -vf framestep=2 -vc mpeg12
/media/mmcblk0p2/matrix_openmoko.mpeg2
it's slow...but the colours are ok