[MPlayer-dev-eng] [PATCH] Report the reason to exit for -identify

rvm rvm3000 at ya.com
Wed Nov 12 00:36:40 CET 2008


El Martes, 11 de Noviembre de 2008 08:33, Reimar Döffinger escribió:
> Hello,
>
> On Mon, Nov 10, 2008 at 11:50:53PM +0100, rvm wrote:
> > Maybe the best would be to change the type of "how" from const char * to
> > an int or enum, and then print one thing or another (in a switch) instead
> > of having to compare the strings, but that would require some deeper
> > changes.
>
> IMO that is the only acceptable solution.
> Also I think you should always print an ID_EXIT even when you do not
> have any "how" set.
> To distinguish the error conditions you could also just use different exit
> codes.

Attached is my first try to make the patch using an enum for the "how" 
parameter.

-- 
rvm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: id_exit_enum.diff
Type: text/x-diff
Size: 7065 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081112/93b53311/attachment.diff>


More information about the MPlayer-dev-eng mailing list