[MPlayer-dev-eng] [PATCH] vf_screenshot, output filename corresponding to the played file

[Uoti Urpala]

On Mon, 2008-11-10 at 09:43 +0100, Attila Kinali wrote:
> On Sun, 9 Nov 2008 22:03:07 +0300
> "Ruslan Savchenko" <ruslan.savchenko at gmail.com> wrote:
> > first patch moves "filename" variable outside of main() to global in
> > mencoder.c
> > second patch is for vf_screenshot
> > and the third one patches the man page
> 
> Uhmm.. shouldn't be filname global to both mplayer and mencoder?
> At least -vf screenshot should work as defined in the manpage
> for mplayer too.

There already is a global "filename" in mplayer.c. However IMO it's a
bad idea for individual filters to rely on such globals existing and
being set to any particular value. Especially when the patch adds a
private "extern char *filename;" declaration in a filter instead of
including a header (but I still wouldn't like it even if it included a
header).