[MPlayer-dev-eng] [PATCH] Report the reason to exit for -identify

Andrew Savchenko Bircoph at list.ru
Mon Nov 10 01:29:42 CET 2008


Hi,

On Monday 10 November 2008 03:08, rvm wrote:
> El Lunes, 3 de Noviembre de 2008 00:35, rvm escribió:
> > Frontends may need to know the reason for what mplayer has
> > exited (quitted by the user, end of file...). It already
> > prints that info with these messages:
> >
> > Exiting... (Quit)
> > Exiting... (End of file)
> >
> > The problem is that those strings are translatable strings. So
> > if mplayer is compiled with another language as default, it
> > will print other strings, making things harder for frontends.
> >
> > To fix the problem I suggest that mplayer would also print
> > some strings for -identify, for example:
> >
> > ID_EXIT=QUIT
> > ID_EXIT=EOF
> > ID_EXIT=ERROR
> >
> > I attach a patch which does that. Although probably it's not
> > implemented in the right way...
>
> No comments?

It looks OK, but I'm not feeling myself brave enough to apply...

P.S. Well, maybe it is better to use switch() block instead of lot 
of 'if' statements?

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081110/80e162a5/attachment.pgp>


More information about the MPlayer-dev-eng mailing list