[MPlayer-dev-eng] separate infrastructure patch?

[Aurelien Jacobs]

On Fri, 30 May 2008 10:12:23 +0200
Nico Sabbi <Nicola.Sabbi at poste.it> wrote:

> On Friday 30 May 2008 04:38:54 Bryan Henderson wrote:
> > I need some advice on submitting a large enhancement.  Should
> > infrastructure changes that (supposedly) have no functional effect
> > by themselves be submitted separately?  Is it better to submit in
> > pieces or all at once?

Separate in small self-contained patch as much as you can.

> > I've attached an example.  This creates the function demux_flush().
> > Five parts of Mplayer have to flush the various demuxer streams (as
> > when the user seeks).  They flush them individually, and not all
> > the same way.  This patch replaces that with five calls to
> > demux_flush(), which flushes all the streams.
> >
> > This matters to closed captioning, because the closed caption
> > stream is one more thing that has to be flushed; it makes one place
> > instead of five for the closed caption patch to patch.
> 
> 
> the patch is good to commit and a perfectly structured

Except that it won't compile (I guess)...
demuxer->television_vbi do not exist for now, and shouldn't be
referenced in your patch.

Aurel