[MPlayer-dev-eng] [PATCH] fix v4l2 free_demuxer crash - uvcvideo

[Ötvös Attila]

Ezzel a dátummal: Friday 30 May 2008 09.46.06 Vladimir Voroshilov ezt írta:
Hi Vladimir Voroshilov!

> This means that drivers reports frameperiod==0.
> I didn't found any requirenments for non-zero frameperiod in V4L2 spec
> does, though.
> But even if  such value is allowed (which sounds strange for me),
> above solution is incomplete,
> because frameperiod is used in other places, too (e.g. A/V sync code).
>
> Are here any v4l2 specialists?
> What do you think ?
>
> Fixing uvcvideo drivers looks more reasonable, imho.

Ok. I rewiev uvcvideo kernel module:

----- start cut from uvc_v4l2.c ----------
	/* Analog video standards make no sense for digital cameras. */
	case VIDIOC_ENUMSTD:
	case VIDIOC_QUERYSTD:
	case VIDIOC_G_STD:
	case VIDIOC_S_STD:

	case VIDIOC_OVERLAY:

	case VIDIOC_ENUMAUDIO:
	case VIDIOC_ENUMAUDOUT:

	case VIDIOC_ENUMOUTPUT:
		uvc_trace(UVC_TRACE_IOCTL, "Unsupported ioctl 0x%08x\n", cmd);
		return -EINVAL;
----- end cut from uvc_v4l2.c ----------

I make new patch.

Best regard.
Attila
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-free_demuxer-crash-v4l2-to-uvcvideo-usb-driver.patch
Type: text/x-diff
Size: 3779 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080530/86de0458/attachment.patch>