[MPlayer-dev-eng] [PATCH] Bugfix in subtitels recoding from stateful encodings

[Evgeniy Stepanov]

On Tuesday 27 May 2008 02:02:55 Evgeniy Stepanov wrote:
> On Monday 26 May 2008 23:13:56 Guy Shapiro wrote:
> > Hi,
> > When using the '-subcp' option to recode a stateful encoding (cp1255 in
> > my case), the last letter of some subtitles are shown only at the start
> > of the trailing subtitle.
> > You can reproduce the bug by playing the attached Srt file with the
> > option '-subcp cp1255'. Instead of showing 3 characters in each subtitle,
> > MPlayer moves the last letters of the Hebrew subtitles to the start of
> > the non-Hebrew subtitles that come after them.
> > This bug is caused by the behaviour of iconv, that saves the encoding
> > state between subtitles and sometimes put a character in the output
> > buffer only after the character next to it is read from the input buffer.
> > The attached patch solves the problem for me.
>
> Indeed, it helps. They do the same thing in the actual iconv program, so it
> must be correct. I'm going to commit this change in a few days.

Applied.