[MPlayer-dev-eng] [PATCH] color SPU

Benjamin Zores ben at geexbox.org
Wed May 28 21:13:09 CEST 2008


Ötvös Attila a écrit :
> Hi All!
> 
> I make color SPU to dvd subtitles and dvd menu.
> 
> The first number show depend in patch.
> 
> part1:
> - add need format def
> - add new paramater (dp) to all draw_alpha() functions
> 
> part2:
> - draw code to U, V, R, G and B planes
> - query SPU format code (VFCTRL_GET_OSD_FORMAT)
> 
> part3:
> - modify spudec.c to UV and RGB planes (scale more plane)
> 
> part4:
> - add draw function to UV plane in vf_expand
> - final modify in mplayer.c
> - new options: -colorspu/-nocolorspu - enable/disable color spu
> 
> part5:
> - add palette variable to stream_dvdnav
> - final modify to spudec
> - add mp_dvdnav_highlight_handle() in mplayer.c

Thanks for this new patchset.
However it's quite a heavy load of patches and lines to be read, so it 
might take a while. The effort is well appreciated however.

I haven't have tested the features to actually see if it works fine or 
not, though I'd really like to have them reviewed/commited to finally be 
done with this feature and have a complete DVDNAV support.

I may however requires review by more than just Nico & myself (DVDNAV 
maintainers), as it involves many changes in libvo/spudec that I'm not 
really familiar with. Hence, it'd be really cool if anyone with a bit of 
knowledge in these areas may help here.

Ben



More information about the MPlayer-dev-eng mailing list