[MPlayer-dev-eng] [PATCH] add slave command for stop playback without to quit MPlayer (useful with -idle)

Benjamin Zores ben at geexbox.org
Tue May 27 20:40:50 CEST 2008


Mathieu SCHROETER a écrit :
> Mathieu SCHROETER a écrit :
>> Diego Biurrun a écrit :
>>> On Fri, Mar 07, 2008 at 03:19:30PM +0100, Mathieu SCHROETER wrote:
>>>> Diego Biurrun a écrit :
>>>>> On Thu, Mar 06, 2008 at 06:36:13PM +0100, Mathieu SCHROETER wrote:
>>>>>> --- mplayer.c    (r??vision 26185)
>>>>>> +++ mplayer.c    (copie de travail)
>>>>>> @@ -3974,6 +3974,9 @@
>>>>>>        mpctx->playtree_iter = NULL;
>>>>>>      }
>>>>>>     }
>>>>>> +} else if (mpctx->eof == PT_STOP) {
>>>>>> +  play_tree_iter_free(mpctx->playtree_iter);
>>>>>> +  mpctx->playtree_iter = NULL;
>>>>>>  } else { // NEXT PREV SRC
>>>>>>       mpctx->eof = mpctx->eof == PT_PREV_SRC ? -1 : 1;
>>>>>>  }
>>>>> Please indent this code with 4 spaces where appropriate.
>>>> Mmmmh.. I think that the problem is not the indent of my patch
>>>> but the lines 3976 and 3981 (with patch applied). The line 3976 uses
>>>> 3 spaces and the line 3981 uses 5 spaces.
>>>> All others lines of this "if {} else if {} [...] else {}"
>>>> use *2* spaces.
>>>
>>> Fixed :)  Now please update your patch accordingly.
>>>
>>
>> Thanks, patch updated.
> 
> Ping..
> 
> something wrong?

Applied.

Ben



More information about the MPlayer-dev-eng mailing list