[MPlayer-dev-eng] fix for broken noconsolecontrols flag

[Bart van Deenen]

Hello Reimar

I don't understand the man page explanation which says
"Prevent MPlayer from reading key events from standard input"

But when I run mplayer as slave, it reads complete command strings  
from standard input, and not key events.
What it does still do is read keypresses from the keyboard, when the  
mplayer window has focus. This is what I want to prevent.
Also, I run mplayer without a window manager, so I dont have any  
close symbol to click.

So I don't understand what noconsolecontrols does. I'll unbind the  
keys I guess.

Thanks

Bart


On May 19, 2008, at 19:00 , Reimar Döffinger wrote:
> Hello,
> On Mon, May 19, 2008 at 04:13:24AM -0300, Bart van Deenen wrote:
>> Starting mplayer as slave, with the -noconsolecontrols does not
>> prevent keypresses from controlling the player when it has focus (on
>> linux, mplayer version 1.0rc2).
>
> Read the man page, it behaves exactly as the name suggests and as  
> it is
> supposed to.
>
>> I had a look in the source, and I
>> think I fixed it with a one-line change in mplayer.c. My player works
>> fine now, and ignores keypresses as it should with the
>> -noconsolecontrols option. I hope I'm right, and that this patch gets
>> into the source tree.
>
> And thus the patch is wrong and rejected. It might would be a good
> idea to add an extra option with an effect like this (though you can
> just unbind the keys manually, too), but this way is probably still a
> bad idea, because it 1) causes keypresses to pile up in the command  
> fifo
> 2) it also breaks handling of clicking the "close" symbol on the upper
> right of the window.
>
> Greetings,
> Reimar Döffinger
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng