[MPlayer-dev-eng] fix for broken noconsolecontrols flag

[Reimar Döffinger]

Hello,
On Mon, May 19, 2008 at 04:13:24AM -0300, Bart van Deenen wrote:
> Starting mplayer as slave, with the -noconsolecontrols does not  
> prevent keypresses from controlling the player when it has focus (on  
> linux, mplayer version 1.0rc2).

Read the man page, it behaves exactly as the name suggests and as it is
supposed to.

> I had a look in the source, and I  
> think I fixed it with a one-line change in mplayer.c. My player works  
> fine now, and ignores keypresses as it should with the  
> -noconsolecontrols option. I hope I'm right, and that this patch gets  
> into the source tree.

And thus the patch is wrong and rejected. It might would be a good
idea to add an extra option with an effect like this (though you can
just unbind the keys manually, too), but this way is probably still a
bad idea, because it 1) causes keypresses to pile up in the command fifo
2) it also breaks handling of clicking the "close" symbol on the upper
right of the window.

Greetings,
Reimar Döffinger