[MPlayer-dev-eng] Make --enable-runtime-cpudetection work again

Bryan Henderson giraffedata at gmail.com
Fri May 16 10:03:43 CEST 2008


A recent change to 'configure' makes --enable-runtime-cpudetection do
only half of what it's supposed to, on a system that doesn't do
Altivec:  it generates code for all the other CPU features (MMX, SSE,
etc), but does not generate the code to check at runtime whether the
features are available.  The result is code that executes instructions
that aren't valid on that CPU.

This patch fixes it.

--- configure   (revision 26786)
+++ configure   (working copy)
@@ -2411,7 +2411,7 @@


 #FIXME: This should happen before the check for CFLAGS..
-if test "$_altivec" = yes || test "$_runtime_cpudetection" = yes ; then
+if test "$_altivec" = yes ; then

     # check if AltiVec is supported by the compiler, and how to enable it
     echocheck "GCC AltiVec flags"

I can't see why the $_runtime_cpudetection should be part of the
decision here.  The real question appears to be just whether we're
going to build Altivec code or not ($_altivec).



More information about the MPlayer-dev-eng mailing list