[MPlayer-dev-eng] [PATCH] Xv Adaptor Selection

[Ivan Kalvachev]

On Wed, May 14, 2008 at 10:22 PM, Benjamin Zores <ben at geexbox.org> wrote:
> Uoti Urpala a écrit :
>> On Wed, 2008-05-14 at 00:40 +0300, Ivan Kalvachev wrote:
>>> On Tue, May 13, 2008 at 8:53 PM, Benjamin Zores <ben at geexbox.org> wrote:
>>>> Benjamin Zores a écrit :
>>>>  > Attached patch adds a new suboption to -vo xv, that can be used to
>>>>  > choose which Xv adaptor
>>>>  > to use to render a video. It is normally possible to do the same
>>
>>> First, you haven't read the manual,
>>> we have "-adapter" option that does the same (for directx). Your patch
>>> doesn't honor it.
>>
>> The -adapter option is documented to select a graphics card, not XV
>> adaptor from options typically using the same card (it's not even quite
>> the same term, "adapter" vs "adaptor"). If you want to change something

According to Oxford and Merriam-Webster dictionaries, this IS the same word.
They don't give details for the origin (other than it adapts), so my
guess is that
one of the words is Americanism.
Using both words would cause even more confusion.

>> I think it would be better to change -adapter from a global option to a
>> directx suboption (unless you want to generalize it to multiple VOs
>> somehow, but I doubt there would be any generalization applicable to
>> multiple VOs that would map to adaptor in XV case).

I do not mind removing the global option.
What I want is consistency.

> That's exactly my point.
> Unfortunately for me, having you on my side makes me public enemy #2 :-)

Don't flatter yourself. You need much more persistence and much more
evil deeds to get the title of public enemy. Not saying that first two
places are already occupied.