[MPlayer-dev-eng] [PATCH] compute correct length for theora videos

[Reimar Döffinger]

On Mon, May 12, 2008 at 08:06:09PM +0200, Julian Kniephoff wrote:
> Am Montag, 12. Mai 2008 15:56:01 schrieb Julian Kniephoff:
> >
> > I have to take a look at the code again because I don't understand it
> > completely, yet. However concerning the seek bar, I think the problem
> > directly lies under the lines I changed: There the "wrong" final_granulepos
> > value is also used without correction to calculate the current "position".
> >
> Lucky hunch ;). Changing the DEMUXER_CTRL_GET_PERCENT_POS case of 
> demux_ogg_control analogous to the original patch fixes the seek bar on my 
> system. Still the patch does not reuse code so I'll have yet another look 
> into it.
> I hope I'm not getting annoying...

Certainly not, I just have a hunch that there is something going fundamentally
wrong and your patches would only fix the symptoms.
E.g. the seeking code uses final_granulepos as well, and probably does
not work right either with only the changes you did so far.
Or saying it differently: I am fairly sure that final_granulepos is
_supposed_ to be in the "fixed" form already.

Greetings,
Reimar Döffinger