[MPlayer-dev-eng] [PATCH] compute correct length for theora videos

[The Wanderer]

Julian Kniephoff wrote:

> Hello,
> 
> this is a patch to let mplayer compute the correct duration of a
> theora video when libtheora support is compiled in (especially when
> running in "-identify mode"). To not repeat myself I'll just post
> links to the important posts of the bug report in the mplayer-users
> list. The baisc concept of the patch is also explained there:
> 
> http://lists.mplayerhq.hu/pipermail/mplayer-users/2007-December/070943.html
> http://lists.mplayerhq.hu/pipermail/mplayer-users/2008-May/072933.html
> 
> If this doesn't suffice, please ask for further clarification.
> 
> The patch is written against the current SVN version (Revision 26728
> according to "svn update", "mplayer" identifies itself as "MPlayer
> 1.0rc2-4.2.3")

This is not consistent; an MPlayer version which had been compiled from
SVN sources would identify itself as "MPlayer dev-SVN-r#####-X.Y.Z",
giving the revision number and the compiler version.

To avoid needing to mention what version a patch is against, and to
guarantee that it will apply to the latest SVN tree, the recommended way
to create a patch is using 'svn diff' from the root of the SVN source
tree. There is a file, DOCS/tech/patches.txt, which explains the basic
rules.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.