[MPlayer-dev-eng] [PATCH] hack: make lavf muxing not segfault

[Reimar Döffinger]

On Fri, May 09, 2008 at 04:03:37PM -0700, Corey Hickey wrote:
> ffmpeg r13061 broke muxing via lavf, and Michael has professed
> reluctance to working on MPlayer at the moment. He suggested a solution
> to me on ffmpeg-cvslog, but his wording was terse and I'm not familiar
> enough with the code to understand what he meant. See the r13061 thread
> on ffmpeg-cvslog.
> 
> Anyway, this patch hacks around the problem. Read the comment in the
> patch to see what's going on.
> 
> I'm hoping this will be rejected, but if it isn't I'll commit the patch
> in three days.

I am not sure it is possible, but this seems a lot like some of the
demux_lavf problems, and if it is possible IMO the best solution is
to get rid of URLProtocol and use av_alloc_put_byte instead of url_fopen
- this is also since there is no unregister_protocol, which means that
mp_protocol will remain registered and will cause a lot of pain if
we ever support protocols through lavf, with Michael's proposed solution
I think that "pain" is even likely to be exploitable unless you are
very, very careful.

Greetings,
Reimar Döffinger