[MPlayer-dev-eng] Local headers are included over system headers

Nico Sabbi Nicola.Sabbi at poste.it
Sat May 3 16:06:13 CEST 2008


Il Saturday 03 May 2008 13:31:54 Diego Biurrun ha scritto:
> On Sat, May 03, 2008 at 01:10:51PM +0300, Uoti Urpala wrote:
> > On Sat, 2008-05-03 at 10:28 +0200, Nico Sabbi wrote:
> > > thus the wrong inclusion is probably due to wrong -I flags.
> > > Can someone give it a look, please?
> > 
> > -I adds directories to the search path for includes using both "" and
> > <>. Thus having the top-level MPlayer source directory in the default -I
> > flags means <dvdread/dvd_reader.h> will be found under the local
> > dvdread/ too. Using -iquote instead of -I adds directories to the search
> > path for includes using "" only, but it is a less standard compiler
> > option than -I. I see no other easy way to avoid the problem by include
> > path changes as long as the files have the current names and locations
> > though.
> 
> Yes, I do not think this can be fixed without renaming the internal
> path.
> 
> Diego

I'm all for the renaming, possibly calling the directory libdvdread.
Go for it as far as I'm concerned



More information about the MPlayer-dev-eng mailing list